Add read only ingester support to lifecycler and ring #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhalterman
changed the title
jhalterman
force-pushed
the
read-only-lifecycler
branch
2 times, most recently
from
ec8c1c3 to
fa98476
Compare
2 tasks
- Updates the ring.proto to support two new fields to support read only ingesters: - read_only - read_only_updated_timestamp - Updates the lifecycler to support reading/writing the new fields - Updates the ring_http support Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
jhalterman
force-pushed
the
read-only-lifecycler
branch
from
fa98476 to
7e7e510
Compare
pracucci
approved these changes
Aug 5, 2024
jhalterman
force-pushed
the
read-only-lifecycler
branch
5 times, most recently
from
a383036 to
1b579bb
Compare
jhalterman
force-pushed
the
read-only-lifecycler
branch
from
1b579bb to
88b2ed7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR is 1 of 2 that will add read-only ingester support to the ring and lifecycler. It's based on proposal 1 in this design doc. This PR:
InstanceDesc:read_onlyread_only_updated_timestampTo keep the scope of this PR reasonable, a followup PR will add support for read only ingesters when computing shuffle shards.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]